| Lists: | pgsql-hackers |
|---|
| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Fix badly generated entries in wait_event_names.txt |
| Date: | 2023-08-07 08:34:43 |
| Message-ID: | e378989e-1899-643a-dec1-10f691a0a105@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi hackers,
fa88928470 introduced src/backend/utils/activity/wait_event_names.txt that has
been auto-generated. The auto-generation had parsing errors leading to bad
entries in wait_event_names.txt (when the same "WAIT_EVENT" name can be found as
a substring of another one, then descriptions were merged in one of them).
Fixing those bad entries in the attached.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-badly-generated-entries-in-wait_event_names.t.patch | text/plain | 4.5 KB |
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix badly generated entries in wait_event_names.txt |
| Date: | 2023-08-07 23:25:49 |
| Message-ID: | ZNF9fQ/zcoPMRMj6@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Aug 07, 2023 at 10:34:43AM +0200, Drouvot, Bertrand wrote:
> fa88928470 introduced src/backend/utils/activity/wait_event_names.txt that has
> been auto-generated. The auto-generation had parsing errors leading to bad
> entries in wait_event_names.txt (when the same "WAIT_EVENT" name can be found as
> a substring of another one, then descriptions were merged in one of them).
Thanks for the patch, applied. I have double-checked the contents of
the tables and the five entries you have pointed out are the only ones
with duplicated descriptions.
--
Michael
| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix badly generated entries in wait_event_names.txt |
| Date: | 2023-08-08 05:31:41 |
| Message-ID: | 9b5282a9-fc04-4bd2-a2f9-309364c09b18@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
On 8/8/23 1:25 AM, Michael Paquier wrote:
> On Mon, Aug 07, 2023 at 10:34:43AM +0200, Drouvot, Bertrand wrote:
>> fa88928470 introduced src/backend/utils/activity/wait_event_names.txt that has
>> been auto-generated. The auto-generation had parsing errors leading to bad
>> entries in wait_event_names.txt (when the same "WAIT_EVENT" name can be found as
>> a substring of another one, then descriptions were merged in one of them).
>
> Thanks for the patch, applied.
Thanks!
> I have double-checked the contents of
> the tables and the five entries you have pointed out are the only ones
> with duplicated descriptions.
Yeah, did the same on my side before submitting the patch, and all looks
good now.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com