| Lists: | pgsql-hackers |
|---|
| From: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Minor code improvement to estimate_path_cost_size in postgres_fdw |
| Date: | 2018-01-11 10:14:33 |
| Message-ID: | 96f2f554-1eeb-fe6f-e0db-650771886781@lab.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
The declaration of estimate_path_cost_size uses baserel, but
the actual definition uses foreignrel. It would be better to sync.
Please find attached a patch.
Tatsuro Yamada
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix_declaration_of_estimate_path_cost_size.patch | text/x-patch | 507 bytes |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Minor code improvement to estimate_path_cost_size in postgres_fdw |
| Date: | 2018-01-11 16:54:54 |
| Message-ID: | 19022.1515689694@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> The declaration of estimate_path_cost_size uses baserel, but
> the actual definition uses foreignrel. It would be better to sync.
Yeah, the join_conds parameter's been renamed at some point too :-(
Fixed.
regards, tom lane
| From: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Minor code improvement to estimate_path_cost_size in postgres_fdw |
| Date: | 2018-01-12 00:42:21 |
| Message-ID: | 61b91e36-9c9a-814c-c74e-26cfc6a4ae45@lab.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2018/01/12 1:54, Tom Lane wrote:
> Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> The declaration of estimate_path_cost_size uses baserel, but
>> the actual definition uses foreignrel. It would be better to sync.
>
> Yeah, the join_conds parameter's been renamed at some point too :-(
> Fixed.
>
> regards, tom lane
Thanks! :)
Regards,
Tatsuro Yamada