| Lists: | pgsql-hackers |
|---|
| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] Improve tab completion for ALTER TABLE on identity columns |
| Date: | 2022-10-12 14:18:46 |
| Message-ID: | 87mta1jfax.fsf@wibble.ilmari.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi Hackers,
I noticed that psql has no tab completion around identity columns in
ALTER TABLE, so here's some patches for that.
In passing, I also added completion for ALTER SEQUECNE … START, which was
missing for some reason.
- ilmari
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-psql-Add-tab-completion-for-ALTER-SEQUENCE-START.patch | text/x-diff | 1.1 KB |
| 0002-psql-Add-tab-completion-for-ALTER-COLUMN-SET-GENERAT.patch | text/x-diff | 2.1 KB |
| 0003-psql-Add-tab-completion-for-ALTER-COLUMN-SET-sequenc.patch | text/x-diff | 2.2 KB |
| 0004-psql-Add-tab-completion-for-ALTER-COLUMN-ADD-GENERAT.patch | text/x-diff | 2.2 KB |
| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns |
| Date: | 2022-10-14 14:31:26 |
| Message-ID: | 87k052jx35.fsf@wibble.ilmari.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> writes:
> Hi Hackers,
>
> I noticed that psql has no tab completion around identity columns in
> ALTER TABLE, so here's some patches for that.
Added to the next commit fest:
https://commitfest.postgresql.org/40/3947/
- ilmari
| From: | Matheus Alcantara <mths(dot)dev(at)pm(dot)me> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns |
| Date: | 2022-10-25 22:45:20 |
| Message-ID: | O6GB3SIM-aNw1FgXVh0AcY-5sOsKOQrbDiBoXZxfYqP0uSQTfr87xf1nd6Lp9fWMad_1P7g0GQu-UqM_106PMpR_VsVFXGKi2CNmVzxZTXg=@pm.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
> Hi Hackers,
>
> I noticed that psql has no tab completion around identity columns in
> ALTER TABLE, so here's some patches for that.
>
> In passing, I also added completion for ALTER SEQUECNE … START, which was
> missing for some reason.
>
> - ilmari
Hi ilmari
I've tested all 4 of your patches, and all of them seem to work as expected.
This is my first time reviewing a patch, so let's see if more experience
hackers has anything more to say about these patches, but at first they
seem correct to me.
--
Matheus Alcantara
| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns |
| Date: | 2022-11-01 11:19:54 |
| Message-ID: | 27b42f79-2743-d806-faf0-23c6ac758a52@enterprisedb.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 14.10.22 16:31, Dagfinn Ilmari Mannsåker wrote:
>> I noticed that psql has no tab completion around identity columns in
>> ALTER TABLE, so here's some patches for that.
>
> Added to the next commit fest:
>
> https://commitfest.postgresql.org/40/3947/
Committed.
| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Matheus Alcantara <mths(dot)dev(at)pm(dot)me>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns |
| Date: | 2022-11-01 11:20:54 |
| Message-ID: | f242cb2a-66d2-1ac2-d76e-1638ec9cc26d@enterprisedb.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 26.10.22 00:45, Matheus Alcantara wrote:
>> I noticed that psql has no tab completion around identity columns in
>> ALTER TABLE, so here's some patches for that.
>>
>> In passing, I also added completion for ALTER SEQUECNE … START, which was
>> missing for some reason.
> I've tested all 4 of your patches, and all of them seem to work as expected.
>
> This is my first time reviewing a patch, so let's see if more experience
> hackers has anything more to say about these patches, but at first they
> seem correct to me.
This was sensible for a first review. Thanks for you help.
| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns |
| Date: | 2022-11-01 11:29:21 |
| Message-ID: | 871qqmkj5a.fsf@wibble.ilmari.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> On 14.10.22 16:31, Dagfinn Ilmari Mannsåker wrote:
>>> I noticed that psql has no tab completion around identity columns in
>>> ALTER TABLE, so here's some patches for that.
>> Added to the next commit fest:
>> https://commitfest.postgresql.org/40/3947/
>
> Committed.
Thanks!
- ilmari