| Lists: | pgsql-hackers |
|---|
| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete |
| Date: | 2023-01-06 10:05:07 |
| Message-ID: | 80db7836-4415-d54a-64c3-66b88b1430e7@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi hackers,
Please find attached a patch to $SUBJECT.
The wrong comments have been discovered by Robert in [1].
Submitting this here as a separate thread so it does not get lost in the logical decoding
on standby thread.
Looking forward to your feedback,
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-fix-some-comments.patch | text/plain | 1.8 KB |
| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete |
| Date: | 2023-03-02 13:04:58 |
| Message-ID: | 86b7297e-13c0-dca0-a723-c687e3878608@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
On 1/6/23 11:05 AM, Drouvot, Bertrand wrote:
> Hi hackers,
>
> Please find attached a patch to $SUBJECT.
>
> The wrong comments have been discovered by Robert in [1].
>
> Submitting this here as a separate thread so it does not get lost in the logical decoding
> on standby thread.
>
> [1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com
>
> Looking forward to your feedback,
>
> Regards,
>
It looks like I did not create a CF entry for this one: fixed with [1].
Also, while at it, adding a commit message in V2 attached.
[1]: https://commitfest.postgresql.org/43/4235/
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-comments-in-gistxlogDelete-xl_heap_freeze_pag.patch | text/plain | 2.6 KB |
| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete |
| Date: | 2023-03-03 11:30:59 |
| Message-ID: | CAA4eK1LhiZ7B-LNTAOBzx38SrnGFGA7kBf65vmUOWRa8sMJ-6Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Thu, Mar 2, 2023 at 6:35 PM Drouvot, Bertrand
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> On 1/6/23 11:05 AM, Drouvot, Bertrand wrote:
> > Hi hackers,
> >
> > Please find attached a patch to $SUBJECT.
> >
> > The wrong comments have been discovered by Robert in [1].
> >
> > Submitting this here as a separate thread so it does not get lost in the logical decoding
> > on standby thread.
> >
> > [1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com
> >
> > Looking forward to your feedback,
> >
> > Regards,
> >
>
> It looks like I did not create a CF entry for this one: fixed with [1].
>
> Also, while at it, adding a commit message in V2 attached.
>
LGTM.
--
With Regards,
Amit Kapila.
| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete |
| Date: | 2023-03-03 16:28:47 |
| Message-ID: | e9e025ca-bf2b-cdcd-3283-3bc7e5ef6d53@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
On 3/3/23 12:30 PM, Amit Kapila wrote:
> On Thu, Mar 2, 2023 at 6:35 PM Drouvot, Bertrand
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>>
>> On 1/6/23 11:05 AM, Drouvot, Bertrand wrote:
>>> Hi hackers,
>>>
>>> Please find attached a patch to $SUBJECT.
>>>
>>> The wrong comments have been discovered by Robert in [1].
>>>
>>> Submitting this here as a separate thread so it does not get lost in the logical decoding
>>> on standby thread.
>>>
>>> [1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com
>>>
>>> Looking forward to your feedback,
>>>
>>> Regards,
>>>
>>
>> It looks like I did not create a CF entry for this one: fixed with [1].
>>
>> Also, while at it, adding a commit message in V2 attached.
>>
>
> LGTM.
>
Thanks for having looked at it!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete |
| Date: | 2023-03-03 17:53:10 |
| Message-ID: | CA+Tgmobe_fj+vWAMYxGhTYJ3sOcN1kkegQceK-cBDY+fpzWuTw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Mar 3, 2023 at 11:28 AM Drouvot, Bertrand
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> Thanks for having looked at it!
+1. Committed.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete |
| Date: | 2023-03-04 08:33:45 |
| Message-ID: | 15ea46fc-bbf2-cadc-df1d-dd4a418d52b2@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
On 3/3/23 6:53 PM, Robert Haas wrote:
> On Fri, Mar 3, 2023 at 11:28 AM Drouvot, Bertrand
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>> Thanks for having looked at it!
>
> +1. Committed.
>
Thanks!
Not a big deal, but the commit message that has been used is not 100% accurate.
Indeed, for gistxlogDelete, that's the other way around (as
compare to what the commit message says).
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete |
| Date: | 2023-03-06 15:08:16 |
| Message-ID: | CA+TgmoZfkCc1Y6-r1iqmYwbdtVV_ruKh+McSabAeppqFCeECUQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sat, Mar 4, 2023 at 3:33 AM Drouvot, Bertrand
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> Indeed, for gistxlogDelete, that's the other way around (as
> compare to what the commit message says).
Woops. Good point.
--
Robert Haas
EDB: http://www.enterprisedb.com