| Lists: | pgsql-hackers |
|---|
| From: | "Jonathan Gonzalez V(dot)" <jonathan(dot)abdiel(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | [OAuth] Missing dependency on oauth_validator test |
| Date: | 2026-01-17 17:20:55 |
| Message-ID: | 6e8f4f7c23faf77c4b6564c4b7dc5d3de64aa491.camel@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
While working in another patch[1] I found that the test for the
oauth_validator was failing when running the test using:
meson test -C build --setup --suite oauth_validator
This was due to the binary `oauth_hook_client` being missing because I
build the code without enabling the OAuth test using `PG_EXTRA_TEST`.
I'm attaching a small patch that add the binary dependency in the
meson.build file, thus, it will be build before running the test.
Regards,
[1] https://commitfest.postgresql.org/patch/6183/
--
Jonathan Gonzalez V. <jonathan(dot)abdiel(at)gmail(dot)com>
EnterpriseDB
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-missing-dependency-oauth_hook_client-on-oauth.patch | text/x-patch | 994 bytes |
| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | "Jonathan Gonzalez V(dot)" <jonathan(dot)abdiel(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [OAuth] Missing dependency on oauth_validator test |
| Date: | 2026-01-27 20:17:21 |
| Message-ID: | CAOYmi+=Jpqsv7_mGLp8oEEfY_y11gG69x-FVttF7KLbBgScNJw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sat, Jan 17, 2026 at 9:31 AM Jonathan Gonzalez V.
<jonathan(dot)abdiel(at)gmail(dot)com> wrote:
> I'm attaching a small patch that add the binary dependency in the
> meson.build file, thus, it will be build before running the test.
Pushed and backpatched, thanks! I missed the conversation in [1],
where this was fixed for the other binaries.
Andres, do you know of any way we could surface these missing deps
with only the "standard" meson/ninja invocations? The only idea I had
was to not build the test executables by default, but I think that
trades a small problem (we occasionally hit a build-time dependency
bug) for a big one (devs fail to notice that a test executable doesn't
compile).
--Jacob
[1] https://postgr.es/m/qh4c5tvkgjef7jikjig56rclbcdrrotngnwpycukd2n3k25zi2%4044hxxvtwmgum
| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | "Jonathan Gonzalez V(dot)" <jonathan(dot)abdiel(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [OAuth] Missing dependency on oauth_validator test |
| Date: | 2026-01-27 22:39:57 |
| Message-ID: | 7upikxtheq6ffhusabmdcsuj427nigzy66cllfqe2njqkc6xxo@j3ibac2lg5y2 |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
On 2026-01-27 12:17:21 -0800, Jacob Champion wrote:
> Andres, do you know of any way we could surface these missing deps
> with only the "standard" meson/ninja invocations?
I don't see a realistic magic solution here, unfortunately.
> The only idea I had was to not build the test executables by default, but I
> think that trades a small problem (we occasionally hit a build-time
> dependency bug) for a big one (devs fail to notice that a test executable
> doesn't compile).
I was thinking that we ought to do that, just to make the compile-hack loop a
bit shorter. If we then run the tests in some CI tasks after cleaning the
build tree, it should find most of the omissions.
Greetings,
Andres Freund