psql: tab completion for \l

Lists: pgsql-hackers
From: Ian Barwick <ian(at)2ndquadrant(dot)com>
To: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: psql: tab completion for \l
Date: 2016-04-30 02:06:38
Message-ID: 5724132E.1030804@2ndquadrant.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers

Hi

Evidently over the past 15 or so years I've never needed to type "\l <TAB>",
but when isolating a single database entry in a cluster with a lot more
databases than most I've encountered, was suprised to notice it didn't work.

Trivial patch attached, will add to next commitfest.

Regards

Ian Barwick

--
Ian Barwick http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, RemoteDBA, Training & Services

Attachment Content-Type Size
psql-tab-complete-backslash-l.patch text/plain 682 bytes

From: Gerdan Santos <gerdan(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Ian Barwick <barwick(at)gmail(dot)com>
Subject: Re: psql: tab completion for \l
Date: 2016-08-17 05:41:46
Message-ID: 20160817054146.21390.29972.pgcf@coridan.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed

I did some tests and found nothing special. The stated resource is implemented correctly.
He passes all regression tests and enables the use of the new features specified.

The new status of this patch is: Ready for Committer


From: Ian Barwick <ian(at)2ndquadrant(dot)com>
To: Gerdan Santos <gerdan(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: psql: tab completion for \l
Date: 2016-08-17 23:24:17
Message-ID: 6ebf77c2-6a84-fee5-5f25-6e3c25db5f24@2ndquadrant.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers

Hi

On 8/17/16 2:41 PM, Gerdan Santos wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> I did some tests and found nothing special. The stated resource is implemented correctly.
> He passes all regression tests and enables the use of the new features specified.
>
> The new status of this patch is: Ready for Committer

Thanks for taking the time to review this!

Regards

Ian Barwick

--
Ian Barwick http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, RemoteDBA, Training & Services


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gerdan Santos <gerdan(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Ian Barwick <barwick(at)gmail(dot)com>
Subject: Re: psql: tab completion for \l
Date: 2016-08-18 15:30:17
Message-ID: 15183.1471534217@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers

Gerdan Santos <gerdan(at)gmail(dot)com> writes:
> I did some tests and found nothing special. The stated resource is implemented correctly.
> He passes all regression tests and enables the use of the new features specified.

> The new status of this patch is: Ready for Committer

Pushed, thanks.

regards, tom lane