Missing type declaration in C triggers uninitvar

[amai]

cppcheck reports a [a.c:9]: (error) Uninitialized variable: dcname for the following incomplete(!) C code (inspired by Samba):

#if 0
#define FSTRING_LEN 256
typedef char fstring[FSTRING_LEN];
#endif

void get_dc_name_via_netlogon(fstring dcname);
void get_dcs() {
   fstring dcname;
   get_dc_name_via_netlogon(dcname);
}

It is not shown for the complete/valid version of the code and not if using C++ mode.

Is this the intended behaviour?

[Daniel Marjamäki]

Is this the intended behaviour?

I believe I wrote a ticket about such code about half a year ago.

I had the idea to look at how all "fstring" variables are used in the code. if there is dcname[..] anywhere then the checker could bailout.

[Daniel Marjamäki]

Replying to danielmarjamaki:

Is this the intended behaviour?

I believe I wrote a ticket about such code about half a year ago.

I had the idea to look at how all "fstring" variables are used in the code. if there is dcname[..] anywhere then the checker could bailout.

oh I have implemented that already. No warning is written for this code:

void get_dc_name_via_netlogon(fstring dcname);
void get_dcs() {
   fstring dcname;
   get_dc_name_via_netlogon(dcname);
   dcname[0]=0;
}

would it be possible somehow to see in the real Samba code that fstring is some array? without seeing the typedef?

[amai]

IMHO not within that translation unit. Quite sure somewhere else in the codebase...

[kidkat]

I cannot reproduce this with any released version since 1.43.

[chrchr]

Still reproduces with head:

cppcheck.exe --enable=all --inconclusive .\foo.c
Checking foo.c ...
foo.c:4:29: error: Uninitialized variable: dcname [uninitvar]
   get_dc_name_via_netlogon(dcname);
                            ^

[kidkat]

It requires --language=c - I was testing with a .cpp file.

[kidkat]

This started with 1.58 and has been bisected to ​https://github.com/danmar/cppcheck/commit/cf84c211ed775c244b7f0b95f7779e0cf149a853.