FP: knownConditionTrueFalse

[orbitcowboy]

#include <string>
#include <vector>

bool bar(const std::string &, std::vector<std::string>&);
bool f(const std::string& p)
{
    std::vector<std::string> data;
    if (!bar(p, data))
    {
        return false;
    }
    if (data.size() != 10U)
    {
        return false;
    }
    for (std::vector<std::string>::iterator it = data.begin(); it != data.cend(); ++it)
    {
        if (it->size() < 9U)
        {
            return false; // << 
        }
        it->erase(it->cbegin(), it->cbegin() + 9U);
    }
    return true;
}

$ gcc -c test.cpp && cppcheck --enable=style test.cpp
Checking test.cpp ...
test.cpp:18:24: style: Condition 'it->size()<9U' is always false [knownConditionTrueFalse]
        if (it->size() < 9U)
                       ^
test.cpp:12:21: note: Assuming that condition 'data.size()!=10U' is not redundant
    if (data.size() != 10U)
                    ^
test.cpp:18:24: note: Condition 'it->size()<9U' is always false
        if (it->size() < 9U)
                       ^

Tested with ​https://github.com/danmar/cppcheck/commit/596f75e2afb87bc7eefa44bec06068582a2d48d2

[chrchr]

Reduced:

bool f(std::vector<std::vector<int>> v) {    
    if (v.size() != 10U)
        return false;

    for (auto it = v.begin(); it != v.end(); ++it) {
        if (it->size() < 9U)
            return false;
        it->erase(it->begin(), it->begin() + 9U);
    }
    return true;
}

[pfultz2]

Fixed by: ​https://github.com/danmar/cppcheck/pull/4254