MapComplete · Forgejo

Hey!

Thanks for opening a PR. This is a theme I've been thinking about too, but I never got around working it out, so thanks for making this!

As outlined above, there are still a few small issues before merging this layer.

Making a theme

But, you'll also have to create a theme (a theme is a collection of one or more layers). It can be very minimal, like just containing a title, description and this layer. An example of such a theme is the drinking water theme which only has the drinking_water-layer.

Adjacent concepts

(The part of the adjacent concepts is optional for merging this pull request, but we'll have to do this. I'm however willing to make this part if it is to intimidating)

However, this theme also offers an opportunity to think about adjacent concepts.

For example: this statue of maria is marked as artwork but not as wayside shrine. It can arguably be tagged as both! If I were walking around with your wayside-shrine theme, I would not see this object on the map and would probably create a duplicate.

With adjacent concepts I do mean objects that quite look like wayside shrines and might erronously be tagged as such; or objects that should be marked as wayside shrines but might also be tagged differently.

For this case, I would propose to create a theme that first has the wayside shrines, but which also shows all the artworks with the artwork-theme (eventually when zoomlevel is > 16). Someone adding a new point will zoom in and thus see the artwork.

The next step is then to modify the artwork layer itself and ask if it acts as a wayside shrine - similarly to the question if it acts as memorial. Note that the default assumption is that it does not act as memorial. At last, we also reuse all memorial questions in the artwork layer. This way, someone browsing artworks might also answer some wayside shrine answers without having to open your theme.

Hey! Thanks for opening a PR. This is a theme I've been thinking about too, but I never got around working it out, so thanks for making this! As outlined above, there are still a few small issues before merging this layer. ## Making a theme But, you'll also have to create a theme (a theme is a collection of one or more layers). It _can_ be very minimal, like just containing a title, description and this layer. An example of such a theme is the [drinking water theme](https://source.mapcomplete.org/MapComplete/MapComplete/src/branch/develop/assets/themes/drinking_water/drinking_water.json) which only has the `drinking_water`-layer. ## Adjacent concepts (The part of the adjacent concepts is optional for merging this pull request, but we'll have to do this. I'm however willing to make this part if it is to intimidating) However, this theme also offers an opportunity to think about *adjacent concepts*. For example: this [statue of maria](https://www.openstreetmap.org/node/5521197053) is marked as *artwork* but not as wayside shrine. It can arguably be tagged as both! If I were walking around with your wayside-shrine theme, I would not see this object on the map and would probably create a duplicate. With *adjacent concepts* I do mean objects that quite look like wayside shrines and might erronously be tagged as such; or objects that should be marked as wayside shrines but might also be tagged differently. For this case, I would propose to create a theme that first has the wayside shrines, but which also shows all the artworks with the `artwork`-theme (eventually when zoomlevel is > 16). Someone adding a new point will zoom in and thus see the artwork. The next step is then to modify the artwork layer itself and ask if it acts as a wayside shrine - similarly to [the question if it acts as memorial](https://source.mapcomplete.org/MapComplete/MapComplete/src/commit/9e8aaab08650c018bc6bf38c26d1f41ecffea8bb/assets/layers/artwork/artwork.json#L821). Note that the [default assumption is that it does _not_ act as memorial](https://source.mapcomplete.org/MapComplete/MapComplete/src/commit/9e8aaab08650c018bc6bf38c26d1f41ecffea8bb/assets/layers/artwork/artwork.json#L847). At last, we also [reuse all memorial questions in the artwork layer](https://source.mapcomplete.org/MapComplete/MapComplete/src/commit/9e8aaab08650c018bc6bf38c26d1f41ecffea8bb/assets/layers/artwork/artwork.json#L862). This way, someone browsing artworks might also answer some wayside shrine answers without having to open your theme.

Read the original on source.mapcomplete.org ↗