From: Nathan Chancellor <nathan@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Nicolas Schier <nsc@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	llvm@lists.linux.dev, linux-kbuild@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Documentation/llvm: drop note about LLVM=0
Date: Thu, 26 Feb 2026 14:43:49 -0700	[thread overview]
Message-ID: <20260226214349.GA1534917@ax162> (raw)
In-Reply-To: <20260226-kbuild-llvm-followup-v1-1-201cc2a492d9@weissschuh.net>
On Thu, Feb 26, 2026 at 10:23:57PM +0100, Thomas Weißschuh wrote:
> Since commit 502678b88cb3 ("kbuild: Reject unexpected values for LLVM=")
> LLVM=0 generates an error instead of silently behaving unexpectedly.
>
> Drop the now unnecessary note.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

It might be worth keeping the note about LLVM=0 not being the same as
omitting LLVM altogether, as neither the documentation nor the error
message will say why that is not a valid value. Maybe:
  ``LLVM=0`` is not the same as omitting ``LLVM`` altogether. If you
  only wish to use certain LLVM utilities, use their respective make
  variables.
I don't feel that strongly about it though. Regardless:
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  Documentation/kbuild/llvm.rst | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst
> index bc8a283bc44b..441d8786fcbc 100644
> --- a/Documentation/kbuild/llvm.rst
> +++ b/Documentation/kbuild/llvm.rst
> @@ -71,10 +71,6 @@ recommend::
>
>  	PATH=/path/to/llvm/:$PATH make LLVM=-14
>
> -``LLVM=0`` is not the same as omitting ``LLVM`` altogether, it will behave like
> -``LLVM=1``. If you only wish to use certain LLVM utilities, use their
> -respective make variables.
> -
>  The same value used for ``LLVM=`` should be set for each invocation of ``make``
>  if configuring and building via distinct commands. ``LLVM=`` should also be set
>  as an environment variable when running scripts that will eventually run
>
> --
> 2.53.0
>

---

next prev parent reply	other threads:[~2026-02-26 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 21:23 [PATCH 0/2] kbuild: Follow-up to "Reject unexpected values for LLVM=" Thomas Weißschuh
2026-02-26 21:23 ` [PATCH 1/2] Documentation/llvm: drop note about LLVM=0 Thomas Weißschuh
2026-02-26 21:43   ` Nathan Chancellor [this message]
2026-02-27  8:10     ` Nicolas Schier
2026-02-26 21:23 ` [PATCH 2/2] tools/build: Reject unexpected values for LLVM= Thomas Weißschuh
2026-02-26 21:45   ` Nathan Chancellor
2026-02-27  8:08     ` Nicolas Schier
2026-03-03 16:48 ` [PATCH 0/2] kbuild: Follow-up to "Reject unexpected values for LLVM=" Nicolas Schier

---

Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20260226214349.GA1534917@ax162 \
    --to=nathan@kernel.org \
    --cc=corbet@lwn.net \
    --cc=justinstitt@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=nsc@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

---

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.