joehni · GitHub

@aaron13100

Copy link Copy Markdown

a java.nio.file.Path converter for enhancement request #33

@forethought-studio

@aaron13100

Copy link Copy Markdown

Author

I'm unclear on the Travis CI requirements because, for example, com.thoughtworks.acceptance.LambdaTest clearly requires Java 8.

thanks

@joehni

Copy link Copy Markdown

Member

Hi Aaron, thanks for the contribution. You may rewrite the PathConverter using no reflection, it is fine for me, if Travis passes JDK 8+7 builds. I will tweak the Maven build to support the older JDKs (the converter will actually be excluded).

remove some reflection.
make the jdk 1.6 build work.

@aaron13100

Copy link Copy Markdown

Author

Great! I've removed the reflection from the converter.

I left it for the call to xstream.alias() though because it creates an alias based on the concrete implementation of java.nio.file.Path (e.g. sun.nio.fs.UnixPath, sun.nio.fs.WindowsFileSystem). I couldn't find a precedent for this in the code.

I couldn't find a way to re-launch the Travis CI builds.

joehni pushed a commit that referenced this pull request

Feb 13, 2016

joehni pushed a commit that referenced this pull request

Feb 13, 2016

@joehni

Copy link Copy Markdown

Member

Thanks!

Read the original on github.com ↗