Fixes whatwg#5802 This patch adds attribute change steps to run the dialog closing steps whenever the open attribute is removed in order to prevent a bad state where the dialog is hidden but modal which renders the rest of the page inert.
Open
Closed
Open
Closed
Merged
5 tasks
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request
Jan 6, 2025
When the dialog's open attribute is removed which closes the dialog, we should make the focus async in order to prevent more script from running inside attribute removal. Context: whatwg/html#10124 (comment) Bug: 3419353 Change-Id: I1b76f003e04b802b1868b427a0faddf5f19a3c5e
Closed
1 task
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request
Jan 10, 2025
…en attribute, a=testonly Automatic update from web-platform-tests Make dialog focus async when removing open attribute When the dialog's open attribute is removed which closes the dialog, we should make the focus async in order to prevent more script from running inside attribute removal. Context: whatwg/html#10124 (comment) Bug: 341935362 Change-Id: I1b76f003e04b802b1868b427a0faddf5f19a3c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6085725 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1402551} -- wpt-commits: 58fd4f845204b88a3ae42b72b613a66e84cbb9f8 wpt-pr: 49929
sadym-chromium pushed a commit to web-platform-tests/wpt that referenced this pull request
Jan 14, 2025
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request
Jan 16, 2025
…en attribute, a=testonly Automatic update from web-platform-tests Make dialog focus async when removing open attribute When the dialog's open attribute is removed which closes the dialog, we should make the focus async in order to prevent more script from running inside attribute removal. Context: whatwg/html#10124 (comment) Bug: 341935362 Change-Id: I1b76f003e04b802b1868b427a0faddf5f19a3c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6085725 Reviewed-by: Di Zhang <dizhanggchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1402551} -- wpt-commits: 58fd4f845204b88a3ae42b72b613a66e84cbb9f8 wpt-pr: 49929 UltraBlame original commit: 17e5e580ddfe60cd7d062ca9cbe0722342cc5638
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request
Jan 16, 2025
…en attribute, a=testonly Automatic update from web-platform-tests Make dialog focus async when removing open attribute When the dialog's open attribute is removed which closes the dialog, we should make the focus async in order to prevent more script from running inside attribute removal. Context: whatwg/html#10124 (comment) Bug: 341935362 Change-Id: I1b76f003e04b802b1868b427a0faddf5f19a3c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6085725 Reviewed-by: Di Zhang <dizhanggchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1402551} -- wpt-commits: 58fd4f845204b88a3ae42b72b613a66e84cbb9f8 wpt-pr: 49929 UltraBlame original commit: 17e5e580ddfe60cd7d062ca9cbe0722342cc5638
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request
Jan 16, 2025
…en attribute, a=testonly Automatic update from web-platform-tests Make dialog focus async when removing open attribute When the dialog's open attribute is removed which closes the dialog, we should make the focus async in order to prevent more script from running inside attribute removal. Context: whatwg/html#10124 (comment) Bug: 341935362 Change-Id: I1b76f003e04b802b1868b427a0faddf5f19a3c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6085725 Reviewed-by: Di Zhang <dizhanggchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1402551} -- wpt-commits: 58fd4f845204b88a3ae42b72b613a66e84cbb9f8 wpt-pr: 49929 UltraBlame original commit: 17e5e580ddfe60cd7d062ca9cbe0722342cc5638
Closed
Closed
5 tasks
Merged
6 tasks
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request
Sep 16, 2025
…en attribute, a=testonly Automatic update from web-platform-tests Make dialog focus async when removing open attribute When the dialog's open attribute is removed which closes the dialog, we should make the focus async in order to prevent more script from running inside attribute removal. Context: whatwg/html#10124 (comment) Bug: 341935362 Change-Id: I1b76f003e04b802b1868b427a0faddf5f19a3c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6085725 Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1402551} -- wpt-commits: 58fd4f845204b88a3ae42b72b613a66e84cbb9f8 wpt-pr: 49929
Open
Closed
Merged
beckysiegel pushed a commit to chromium/chromium that referenced this pull request
Jun 9, 2026
I created a bug for this behavior change. The relevant spec issues are still open: - whatwg/html#5802 - whatwg/html#10124 But let's keep the flag for now. Bug: 520262209 Fixed: 518845155 Change-Id: I5a4e6ddce5793b87652460812f4437fe0880b78a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7905833 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1643539}
This was referenced
Jun 30, 2026Merged
Merged