charles-cooper · GitHub

the use of `set` (which does not guarantee order of its elements)
instead of `dict` (which guarantees insertion order) led to instability
across runs of the compiler between different versions of python. this
commit patches the problem by using a derivation of `dict` to track the
call graph instead of `set`.

@codecov-commenter

Codecov Report

Merging #3370 ( 81133dc ) into master ( 7c3cf61 ) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3370      +/-   ##
==========================================
- Coverage   88.88%   88.73%   -0.15%     
==========================================
  Files          85       85
  Lines       10706    10709       +3
  Branches     2233     2233
==========================================
- Hits         9516     9503      -13     
- Misses        788      805      +17     
+ Partials      402      401       -1     
Impacted Files Coverage Δ
vyper/semantics/types/function.py 84.70% <100.00%> (ø)
vyper/utils.py 83.25% <100.00%> (+0.25%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@charles-cooper

pcaversaccio

pcaversaccio

fubuloubu

@charles-cooper

fubuloubu

@charles-cooper

@charles-cooper

This was referenced

Jul 21, 2023

Merged

Closed

Closed

Read the original on github.com ↗