ti-chi-bot · GitHub

@brson

Copy link Copy Markdown

Contributor

Signed-off-by: Brian Anderson andersrb@gmail.com

What problem does this PR solve?

Issue: #6402

Problem Summary:

tikv uses RocksEngine directly and should not

What is changed and how it works?

This just replaces a single test instance of RocksEngine with KvTestEngine.

Related changes

Check List

Release note

  • No release note
Signed-off-by: Brian Anderson <andersrb@gmail.com>

@ti-chi-bot ti-chi-bot added the size/XS

Denotes a PR that changes 0-9 lines, ignoring generated files.

label

Mar 18, 2021

@brson

@kennytm

Copy link Copy Markdown

Contributor

@kennytm

Copy link Copy Markdown

Contributor

/lgtm

@5kbpers

Copy link Copy Markdown

Member

/lgtm

@ti-chi-bot

Copy link Copy Markdown

Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 5kbpers
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@5kbpers

Copy link Copy Markdown

Member

/merge

@ti-chi-bot

Copy link Copy Markdown

Member

@5kbpers: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot

Copy link Copy Markdown

Member

This pull request has been accepted and is ready to merge.

Details Commit hash: 7c3e0a8

@ti-chi-bot

@ti-chi-bot

Copy link Copy Markdown

Member

@brson: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot

Read the original on github.com ↗