Contributor
Signed-off-by: Brian Anderson andersrb@gmail.com
What problem does this PR solve?
Issue: #6402
Problem Summary:
tikv uses RocksEngine directly and should not
What is changed and how it works?
This just replaces a single test instance of RocksEngine with KvTestEngine.
Related changes
Check List
Release note
- No release note
ti-chi-bot
added
the
size/XS
label
Mar 18, 2021Member
[REVIEW NOTIFICATION]
This pull request has been approved by:
- 5kbpers
- kennytm
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
DetailsReviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.
Member
@5kbpers: It seems you want to merge this PR, I will help you trigger all the tests:
/run-all-tests
You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
If you have any questions about the PR merge process, please refer to pr process.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
Member
This pull request has been accepted and is ready to merge.
Details Commit hash: 7c3e0a8Member
@brson: Your PR was out of date, I have automatically updated it for you.
At the same time I will also trigger all tests for you:
/run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.