5kbpers · GitHub

Conversation

@brson

Copy link Copy Markdown

Contributor

What problem does this PR solve?

Add some API docs to engine_traits.

Related changes

#6402

Check List

Release note

  • No release note.
Signed-off-by: Brian Anderson <andersrb@gmail.com>

5kbpers

nrc

nrc approved these changes Jun 9, 2020

@nrc nrc left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sre-bot

Copy link Copy Markdown

Contributor

/run-all-tests

@sre-bot

Copy link Copy Markdown

Contributor

@brson

Copy link Copy Markdown

Contributor Author

/merge

@sre-bot

Copy link Copy Markdown

Contributor

Sorry @brson, you don't have permission to trigger auto merge event on this branch. You are not a committer

@brson

Copy link Copy Markdown

Contributor Author

/merge

@ti-srebot

Copy link Copy Markdown

Contributor

Sorry @brson, you don't have permission to trigger auto merge event on this branch. You are not a committer

@yiwu-arbug

Copy link Copy Markdown

/merge

@ti-srebot

Copy link Copy Markdown

Contributor

/run-all-tests

@ti-srebot

Read the original on github.com ↗