Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried to run this, but it looks incorrect to me since Cargo.toml and tests/Cargo.toml support a different set of features, so passing the same ${ENABLE_FEATURES} to both is going to end up passing the wrong features to some of them.

I think the solution is to wire up Cargo.toml's features to activate various tests/Cargo.toml features. In particular, to solve the linked issue to add

failpoints = ["fail/failpoints", "tests/failpoints"]

I'm idly poking at a patch locally to try that.