hadley · GitHub

@krlmlr

Copy link Copy Markdown

Member

  • legible error message for raw types which cannot be handled currently
  • show message if types are incompatible and convert = TRUE
  • tests

@hadley

Copy link Copy Markdown

Member

LGTM

@hadley

Copy link Copy Markdown

Member

Can you please squash? (That'll also rerun travis now that everything is working again)

@hadley

Copy link Copy Markdown

Member

I think this needs some changes post #1815 - px and py can never be zero now.

I also see

df <- data_frame(a = 1:3, b = as.raw(1:3))
all.equal(df, df)
#> Unsupported vector type 0x7fef4b05a528

And I can't figure out why - the code in subset_visitor() looks fine to me.

@hadley

Copy link Copy Markdown

Member

@hadley

Copy link Copy Markdown

Member

Do you have time to merge/rebase in the next couple of days? If not, no problems, but I'll probably do myself (just to get everything squared away for the dplyr release)

@krlmlr

Copy link Copy Markdown

Member Author

I'll do this by tomorrow.

Kirill Müller added 6 commits

June 1, 2016 01:05

Kirill Müller

Kirill Müller

Kirill Müller

Kirill Müller

Kirill Müller

Kirill Müller

@krlmlr

Kirill Müller

@krlmlr

Kirill Müller

no need to check px and py

@krlmlr

Copy link Copy Markdown

Member Author

Done.

@hadley

@hadley

Copy link Copy Markdown

Member

Thanks!

@lock

Copy link Copy Markdown

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock Bot locked and limited conversation to collaborators

Jan 18, 2019

Read the original on github.com ↗