bastimeyer · GitHub

Copy link Copy Markdown

Member

Yesterday I extended the API quickstart guide and mentioned importing plugins directly (#6464). This requires that the input URL must match. There's no check for this though, which means that if the plugin was not imported by the session's URL resolver, arbitrary URLs could be set on the plugin's constructor. For example, if a plugin relies on certain non-optional regex capture groups of a particular matcher, or if multiple matchers are checked and there's an else-block for a check of the first matcher, then the plugin could break, because there's no guarantee that a valid URL was passed.

So let's check for at least one match if matchers are defined. If no matchers are defined, then ignore this.

Read the original on github.com ↗