bastimeyer · GitHub

Thanks for the PR.

I made some modifications to the PR, since there were a couple of issues. Fixing and improving them myself was quicker than reviewing and annotating the changes. The PR branch of your fork (which unfortunately is master) has been updated and force-pushed.

  • I fixed the commit message and commit authorship (the previous commit author was using a different GH account), and I added myself to the co-authors
  • I removed the unnecessary urllib import and simply set the embedder query string parameter via requests' params request parameter
  • The lequipe matcher has been changed, so that other kinds of videos are supported on the site, like VODs for example
  • And most importantly, the updated changes allow for easier addition for other sites which embed the dailymotion player. The video ID is now extracted from the HTML response, rather than the input URL.
$ HTTPS_PROXY=socks5h://localhost:1920 ./script/test-plugin-urls.py dailymotion
:: https://www.dailymotion.com/embed/video/x8dmdzz
::  288p, 480p, 720p, 1080p, worst, best
:: https://www.dailymotion.com/france24
:::: No live streams found for channel france24
!! No streams found
:: https://www.dailymotion.com/video/x8dmdzz
::  288p, 480p, 720p, 1080p, worst, best
:: https://www.lequipe.fr/tv/replay/le-resume-de-la-mass-start-du-grand-bornand/20201780
::  288p, 480p, 720p, 1080p, worst, best
:: https://www.lequipe.fr/tv/videos/live/k3HiS3JB0BsORKqwC49
::  180p, 288p, 477p, 720p, 1080p, worst, best

Read the original on github.com ↗