bastimeyer · GitHub

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Changes look fine.

However, should there be a need for extending the validation schemas even further, then I'd say that the error handling code should be moved from the Plugin subclass (_get_live() and _get_video()) to the API class. The error handling is currently done in the Plugin subclass, so that it can simply return None instead of having to raise a NoStreamsError in the API class. Irrelevant here though, just a quick thought...

Talking about error handling, are VODs also affected by a potential None return type?

Read the original on github.com ↗