bastimeyer · GitHub

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a benefit to adding this as the use cases are extremely slim and environment variables are easily managed via rc files. If an application is setting a dynamic value for something such as a port (which is already bad behavior on the application's part as typically a default port would be configured via the application's config file) then the application should be setting the environment variable appropriately when the service spins up and the random port is allocated if that port is needed for whatever reason.

That being said as there are no real standards around environment variable usage or expectations and there's little negative impact on Streamlink by adding this. I'll mark it as approved with the caveat that we offer as little support for this feature as possible. People should use wrapper scripts in most situations.

Read the original on github.com ↗