bastimeyer · GitHub

Conversation

@bastimeyer

Copy link Copy Markdown

Member

If super().close() doesn't get called in SegmentedStreamReader.close(), then closed won't be set to True.
https://docs.python.org/3/library/io.html#io.IOBase.close

Noticed that while working on a solution for #4642

@gravyboat

gravyboat merged commit 485a5b5 into streamlink:master

Nov 16, 2022

@bastimeyer

bastimeyer deleted the stream/segmented/close branch

November 16, 2022 11:26

Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request

Dec 4, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants

@bastimeyer @gravyboat

Read the original on github.com ↗