bastimeyer · GitHub

- Remove redundant commands with `.exe` suffixes.
  `shutil.which` will pick those up via `PATHEXT` on Windows.
- Move executable lookup to `FFMPEGMuxer.resolve_command`, so its inputs
  and return values can be cached using `functools.lru_cache` without
  relying on a Streamlink session instance as input
- Keep interface of `FFMPEGMuxer.is_usable` and `FFMPEGMuxer.command`
- Add proper tests

@bastimeyer

@gravyboat

@bastimeyer

bastimeyer deleted the stream/ffmpegmux/cache-executable-lookups branch

July 20, 2022 22:23

Merged

Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request

Jul 23, 2022
- Remove redundant commands with `.exe` suffixes.
  `shutil.which` will pick those up via `PATHEXT` on Windows.
- Move executable lookup to `FFMPEGMuxer.resolve_command`, so its inputs
  and return values can be cached using `functools.lru_cache` without
  relying on a Streamlink session instance as input
- Keep interface of `FFMPEGMuxer.is_usable` and `FFMPEGMuxer.command`
- Add proper tests

Read the original on github.com ↗