- always exit streamlink_cli.main.main at the same function call, namely
  log_current_arguments
- patch out dummy functions in context manager
- slice debug log mock calls due to common test exit function
- properly reset mocks
- rename streamlink_cli.main.check_root to log_root_warning
- add test for streamlink_cli.main.log_root_warning

- refactor streamlink_cli.main.{setup_logging,setup_console}
  and split into setup_logger_and_console and setup_signals
- add LOG_DIR to streamlink_cli.constants
- pass filename to logger.basicConfig
- re-use write stream of logger in ConsoleOutput
- fix escaped chars for percent-formatted argparse help strings in docs
- add tests

Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request

- always exit streamlink_cli.main.main at the same function call, namely
  log_current_arguments
- patch out dummy functions in context manager
- slice debug log mock calls due to common test exit function
- properly reset mocks
- rename streamlink_cli.main.check_root to log_root_warning
- add test for streamlink_cli.main.log_root_warning

Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request

based on streamlink#3753
cannot implement because many issues with py2, py3, no py2 pathlib
no tests applied yet

Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request

based on streamlink#3753
the implementation don't use pathlib and therefore not all tests applied

Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request

based on streamlink#3753
- os.path is used instead of pathlib
- only basic logfile tests w/o write_file_and_assert()

Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request

based on streamlink#3753
- os.path is used instead of pathlib
- only basic logfile tests w/o write_file_and_assert()

Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request

based on streamlink#3753
cannot implement because many issues with py2, py3, no py2 pathlib
no tests applied yet

snorkelopstesting1-a11y pushed a commit to snorkel-marlin-repos/streamlink_streamlink_pr_3753_7069badb-3d19-4f59-8ccd-accbff0fe004 that referenced this pull request

Merged