Member

This removes the following deprecated/suppressed CLI arguments:

• --http-cookies
  Multiple --http-cookie arguments need to be used
• --http-headers
  Multiple --http-header arguments need to be used
• --http-query-params
  Multiple --http-query-param arguments need to be used
• --no-version-check
  Version checking is opt-in via --version-check or --auto-version-check
• --twitch-oauth-authenticate
  Auth on Twitch is not possible with OAuth tokens generated by 3rd-party client-IDs like Streamlink's

And the following deprecated/suppressed plugin arguments:

• --btv-username / --btv-password
• --crunchyroll-locale
  Generic --locale argument needs to be used
• --pixiv-username / --pixiv-password
• --twitch-oauth-token / --twitch-cookie
  As a workaround, --http-header="Authorization=OAuth oauth-token-from-twitch-website" can be used
• --ustvnow-station-code
• --youtube-api-key

Member Author

There's also the issue with the various mux-subtitles plugin arguments and merging them all into one global argument. Ideally, this should be done in the 2.0.0 release due to the major version bump, but it's optional.

Member

There's also the issue with the various mux-subtitles plugin arguments and merging them all into one global argument. Ideally, this should be done in the 2.0.0 release due to the major version bump, but it's optional.

It really seems like the preferable way to go while breaking changes are already being made, otherwise I guess Streamlink will be stuck with the current implementation until release 3.0.0.

Member

Looks good to me!

Member

@bastimeyer how would you merge those mux subtitles options?

Member Author

By adding one global --mux-subtitles boolean parameter and removing the individual plugin parameters from

• funimationnow
• pluzz
• rtve
• svtplay
• vimeo

and making the plugins read the global parameter value instead. Looks like a simple change to be honest.

Member

Yeah, my only concern is that users might assume a plugin supports mux-subtitles where it does not.

Member Author

An info log message could be added to each of the supported plugins. Maybe even as a decorator, to unify the log message.