Conversation
Member
Closes https://github.com/sourcegraph/sourcegraph/issues/17070
- All services now export a Gauge,
src_service_metadata, indicating their Sourcegraph version (and possibly other metadata in the future)- There's precedent for this usage of Gauge, see monitoring: export Sourcegraph version as metric, render annotation in Grafana on version changes #17070
- Add a (currently disabled by default) annotation layer for each service that adds an annotation per version/instance when version labels change.
- Add a (currently disabled by default) annotation layer for each service that shows all service alerts
Open to ideas for annotation formatting (also considering v{{ version }} detected, etc.)
Treating this mostly as a first-pass - I think we can add additional things like links, etc and maybe do better grouping/formatting based on how this looks in dogfood and Cloud
Contributor
Notifying subscribers in CODENOTIFY files for diff fa28c07...fb86e02 .
| Notify | File(s) |
|---|---|
| @keegancsmith | internal/debugserver/debug.go internal/debugserver/metadata.go |
| @slimsag | monitoring/monitoring/README.md monitoring/monitoring/monitoring.go |
| @sourcegraph/distribution | monitoring/monitoring/README.md monitoring/monitoring/monitoring.go |
Codecov Report
Merging #17198 ( fb86e02 ) into main ( fa28c07 ) will decrease coverage by
0.00%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #17198 +/- ## ========================================== - Coverage 51.99% 51.98% -0.01% ========================================== Files 1703 1703 Lines 84804 84804 Branches 7609 7679 +70 ========================================== - Hits 44095 44087 -8 - Misses 36807 36815 +8 Partials 3902 3902
| Flag | Coverage Δ | |
|---|---|---|
| go | 51.04% <ø> (ø) |
|
| integration | 30.50% <ø> (-0.02%) |
⬇️ |
| storybook | 30.03% <ø> (ø) |
|
| typescript | 54.26% <ø> (-0.04%) |
⬇️ |
| unit | 34.80% <ø> (ø) |
| Impacted Files | Coverage Δ | |
|---|---|---|
| .../user/settings/profile/UserSettingsProfilePage.tsx | 55.55% <0.00%> (-22.23%) |
⬇️ |
| .../src/user/settings/profile/EditUserProfileForm.tsx | 72.00% <0.00%> (-20.00%) |
⬇️ |
| client/web/src/nav/StatusMessagesNavItem.tsx | 87.71% <0.00%> (+1.75%) |
⬆️ |
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😻
bobheadxi
changed the title
monitoring: export version info, add annotations on version changes
monitoring: export version info, add annotations on versions, alerts
bobheadxi
changed the title
monitoring: export version info, add annotations on versions, alerts
monitoring: version metric, annotations on versions and alerts
Merged
1 task
Merged
Merged
Labels
None yet


