bobheadxi · GitHub

@bobheadxi

@bobheadxi

@codecov

Codecov Report

Merging #12756 into main will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12756   +/-   ##
=======================================
  Coverage   50.82%   50.82%
=======================================
  Files        1439     1439
  Lines       81094    81094
  Branches     6606     6618   +12
=======================================
+ Hits        41212    41216    +4     
+ Misses      36328    36326    -2     
+ Partials     3554     3552    -2     
Flag Coverage Δ
#go 52.21% <ø> (+<0.01%) ⬆️
#integration 24.20% <ø> (ø)
#storybook 12.72% <ø> (ø)
#typescript 47.01% <ø> (ø)
#unit 47.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../internal/codeintel/resolvers/graphql/locations.go 87.27% <0.00%> (+3.63%) ⬆️

@codecov

Codecov Report

Merging #12756 into main will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12756   +/-   ##
=======================================
  Coverage   51.14%   51.14%
=======================================
  Files        1446     1446
  Lines       81036    81036
  Branches     6627     6615   -12
=======================================
+ Hits        41444    41445    +1     
+ Misses      36032    36031    -1     
  Partials     3560     3560           
Flag Coverage Δ
#go 52.60% <ø> (ø)
#integration 24.27% <ø> (+<0.01%) ⬆️
#storybook 14.12% <ø> (ø)
#typescript 47.13% <ø> (+<0.01%) ⬆️
#unit 47.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/tree/TreeRoot.tsx 81.03% <0.00%> (+1.72%) ⬆️

@bobheadxi bobheadxi changed the title monitoring: use ratios instead of hard thresholds monitoring(frontend): use ratios instead of hard thresholds

Aug 6, 2020

@bobheadxi

bobheadxi marked this pull request as ready for review

August 6, 2020 02:52

@bobheadxi

@bobheadxi

…ring/ratio-instead-of-hard
…ring/ratio-instead-of-hard

keegancsmith

tsenart

- _frontend: 5%+ hard error search API responses every 5m_

- _frontend: 20+ hard error search API responses every 5m_
- _frontend: 20%+ hard error search API responses every 5m_
…ring/ratio-instead-of-hard

Merged

emidoots

…ring/ratio-instead-of-hard
…ring/ratio-instead-of-hard

@bobheadxi

@bobheadxi

bobheadxi deleted the monitoring/ratio-instead-of-hard branch

August 8, 2020 07:11

This was referenced

Aug 8, 2020

Closed

Merged

Merged

bobheadxi added a commit that referenced this pull request

Aug 11, 2020
…ternal_api_error_responses (#12882)
Convert more alerts to ratios, in an effort to provide more meaningful feedback on larger instances (most notably Sourcegraph Cloud). See #12756 for related rationale.

Read the original on github.com ↗