GavynHolt · GitHub

Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Hello!

We at RSPNDR are dealing with Data-Only push notifications lately and have been unfortunately blocked by Skip's missing support for this. When the "notification" property (for example for the title and body of a push notification) is missing, the onMessageReceived function performs an early return which ignores the notification.

For us on the iOS side, this is working perfectly fine but requires an additional application delegate function to be implemented, so I've added some details in the documentation regarding this, including some notes about the possible requirement to disable swizzling.

On the Android side, I have implemented an additional custom "Messaging" didReceiveRemoteMessage function which is only triggered ever in the Android app. It didn't seem at all possible to make use of the UserNotificationCenter, so I hope this is an acceptable side step.

I have tested thoroughly that background notifications are indeed working on both iOS and Android, and the original banner-style push notifications are still working as originally designed.

Closes #86

Read the original on github.com ↗