mrobinson · GitHub

Merged

Merged

@mrobinson

@mrobinson mrobinson changed the title layout: Consistenly use Stylo's more complete get_used_transform_style layout: Make the implementation of used TransformStyle more complete

Jun 13, 2026

@mrobinson

mrobinson marked this pull request as ready for review

June 13, 2026 06:19

@mrobinson

@mrobinson

@mrobinson

Open

@mrobinson

@mrobinson

@mrobinson

Loirooriol

@Loirooriol

Stylo was using a very incomplete method for calculating the used
`TransformStyle` for boxes, which didn't incorporate all of the grouping
properties from the specification. This change moves the functionality
into Servo (as cannot properly compute this value without
`FragmentFlags`) and makes it more complete. We still do not process the
value of `contain`, `mask-iamge`, and `mask-boarder-source` as we do not
support those values yet.
Incidentally, this also fixes a panic that we were causing in WebRender,
probably by going down a path that Gecko does not exercise.
Stylo PR: servo/stylo#388
Signed-off-by: Martin Robinson <martin@abandonedwig.info>

@mrobinson

@mrobinson

@mrobinson

lukewarlow pushed a commit to lukewarlow/stylo that referenced this pull request

Jun 16, 2026
…servo#388)
It's not possible to properly calculate these only looking at style,
because the results depends on the used `overflow` value.
Servo PR: servo/servo#45629
Signed-off-by: Martin Robinson <martin@abandonedwig.info>

@github-merge-queue

@Loirooriol

@Loirooriol

Loirooriol pushed a commit to servo/stylo that referenced this pull request

Jul 1, 2026
…#388)
It's not possible to properly calculate these only looking at style,
because the results depends on the used `overflow` value.
Servo PR: servo/servo#45629
Signed-off-by: Martin Robinson <martin@abandonedwig.info>

Read the original on github.com ↗