TimvdLippe · GitHub

Gae24

Comment on lines +202 to +203

let promise = Promise::new2(cx, global);
promise.reject_native_with_cx(cx, &error);

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This could be Promise::new_rejected (speaking of which new_resolved and new_rejected could be the next ones to convert, I think all have a cx now).

Copy link Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes new_rejected I will do after these two PRs merge.

Comment on lines +229 to +230

let promise = Promise::new2(cx, global);
promise.reject_native_with_cx(cx, &error);

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Read the original on github.com ↗