Merged

mrobinson marked this pull request as ready for review

June 12, 2026 13:57

…argeting algorithm
Browsers still, in practice, disagree about what `elementsFromPoint` and
`elementFromPoint` should return, but ther is a CSSWG resolution that we
can follow from last month: w3c/csswg-drafts#556
This change implements the resolution and also fixes a panic that was
resulting from returning an element within a UA shadow tree.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>

jdm approved these changes Jun 14, 2026

mrobinson deleted the retarget-elementFromPoint branch

June 14, 2026 18:02

TG199 pushed a commit to TG199/servo that referenced this pull request

Jun 21, 2026

…argeting algorithm (servo#45612)
Browsers still, in practice, disagree about what `elementsFromPoint` and
`elementFromPoint` should return, but there is a CSSWG resolution that
we
can follow from last month:
w3c/csswg-drafts#556
This change implements the resolution and also fixes a panic that was
resulting from returning an element within a UA shadow tree.
Testing: This change includes a new crash test. A decent number of tests
start to pass, a group of `<select>` element tests that were failing now
fail
in a different way (a WebDriver `CRASH` which doesn't indicate a real
crash,
but an unexpected state). The only new failure is
`negativeMargins.html`,
where it seems that not filtering every non-`Element` as before is
revealing
some issues with hit testing/layout.
Fixes: servo#45170.
Fixes: servo#40973.
Fixes: servo#44302.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>