alice · GitHub

@alice

delan

@alice

delan

@alice

@delan

delan

delan

delan

delan

@delan

@alice

delan

delan

@alice

@alice

alice marked this pull request as ready for review

May 22, 2026 14:12

@alice

alice

@alice

@alice alice changed the title layout: Root nodes which correspond to accessibility tree nodes. layout: Root unbound nodes until next reflow is finished.

May 26, 2026
Signed-off-by: Alice Boxhall <alice@igalia.com>
Signed-off-by: Alice Boxhall <alice@igalia.com>
…abled`
Also check whether accessibility is *active* before rooting nodes.
Signed-off-by: Alice Boxhall <alice@igalia.com>
- Use debug_assert!() for pref assertions
- Don't check pref before checking accessibility_enabled().
Signed-off-by: Alice Boxhall <alice@igalia.com>
Signed-off-by: Alice Boxhall <alice@igalia.com>
Signed-off-by: Alice Boxhall <alice@igalia.com>
Signed-off-by: Alice Boxhall <alice@igalia.com>
Signed-off-by: Alice Boxhall <alice@igalia.com>

@alice

- Rename methods on AccessibilityData to remove redundant "_for_accessibility()"
- Remove pref check for unroot_all_removed_nodes() which just calls clear() on an empty hash set if the pref is off
- Add convenience method on Document to check for accessibility active.
Signed-off-by: Alice Boxhall <alice@igalia.com>
since we now use it without checking the pref in Window::reflow().
Signed-off-by: Alice Boxhall <alice@igalia.com>

mrobinson

@mrobinson

@github-merge-queue

@delan

@github-merge-queue

@eerii

@alice

alice deleted the accessibility-root-nodes branch

June 10, 2026 14:33

Read the original on github.com ↗