Copy link
Copy Markdown
Member
Copy link
Copy Markdown
Contributor
Copy link
Copy Markdown
Member Author
Seems like @Narfinger was also working on this in #44405
How should we proceed? Should I take over and add @Narfinger as co-author?
Co-authored-by: Narfinger <Narfinger@users.noreply.github.com> Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Copy link
Copy Markdown
Member Author
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy fix, nice! Let's wait to confirm @Narfinger is okay with this and then we can merge.
Copy link
Copy Markdown
Contributor
Yeah if it is ready you can merge it. I got stuck somewhere with too many changes.
