Contributor

Thanks for the PR! Perhaps this could use winapi instead of vendoring large parts of the standard library? (may also help readability as well)

Practically all of that windows api stuff should be available in winapi.

Contributor

Neat! I agree that it would be better to use winapi here, and I'd also prefer if you would publish remove_dir_all as a crate so others can use it as well.

Contributor

Next thing to do here is extract the function to its own crate, convert it to use winapi and then use that crate in tempdir.

Contributor Author

I have pulled it out into a new crate, remove_dir_all which now uses winapi.

Contributor

@Aaronepower I opened a pr on remove_dir_all that should fix the build issue

Contributor

@Aaronepower thank you! Looks like there's a bit more to do here before merging, but thanks for picking it up again.

Contributor Author

@brson I've updated it with @pwoolcoc 's changes. Seems like it works fine now!