Copy link
Copy Markdown
Contributor
We don't need a new type here thanks to serde's remote. This is a follow-up to #22753 (comment).
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy link
Copy Markdown
Member
I am confused, what is the benefit of reusing rust's Result here? We need a duplicate anyways for serde derive. Imo we should stick with the original change here
Copy link
Copy Markdown
Contributor
Because it is a public field and Result is nice and well known.
Copy link
Copy Markdown
Contributor Author
another benefit i can think of: being able to use ?
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
