Copy link Copy Markdown

Member

No description provided.

Copy link Copy Markdown

Contributor

What is the impact on analysis-stats times?

Copy link Copy Markdown

Member Author

Was waiting on CI for that. Surprisingly, none?

Times from #22789

Inference:           96.47s, 832mb
Total:               139.50s, 1426mb

vs this PR

Inference:           97.78s, 840mb
Total:               141.06s, 1426mb

Copy link Copy Markdown

Contributor

CI runs in debug, it's not a reliable benchmark.

Also, benchmarking even the same machine in different times is not a good idea, doubly so a CI machine.

Copy link Copy Markdown

Member Author

Fair enough, it does work as a decent indicator usually though. Can't check the timings for this today

Copy link Copy Markdown

Member Author

baseline
Inference: 37.07s, 956mb
this PR
Inference: 37.89s, 969mb

So yea its within noise (with slight memory increase, since presumably we fill out a couple more query slots)

Copy link Copy Markdown

Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Veykril deleted the lukaswirth/push-lnrnonstwsns branch

Closed