Copy link Copy Markdown

Contributor

Remove #[macro_escape], which was deprecated at the end of 2014 (c.f 5bf385b ).
#[macro_escape] is allowed with a deprecation warning on stable, so this is a [breaking-change].
r? @eddyb

Copy link Copy Markdown

Contributor Author

Merged

Copy link Copy Markdown

Contributor

LGTM. @rust-lang/compiler, looks like this should've been removed before 1.0 - can we do that now?

Copy link Copy Markdown

Member

Copy link Copy Markdown

Collaborator

☔ The latest upstream changes (presumably #36601) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link Copy Markdown

Member

ping r? @eddyb, perhaps this should be nominated for a compiler team discussion?

nikomatsakis added T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

and removed T-lang

Relevant to the language team

labels

Nov 3, 2016

Copy link Copy Markdown

Contributor

This is really a @rust-lang/compiler team problem.

Wearing my compiler hat, I propose that we do a quick crater run to see if anyone is affected and remove it. Basically the normal bug fix protocol. At worst, we can have a warning period, but this seems like one of those cases where it's probably not needed.

Copy link Copy Markdown

Contributor

We can actually skip crater and just (rip)grep the sources of crates.io I guess, even easier.

brson added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Nov 9, 2016

Copy link Copy Markdown

Contributor

This looks like it removes all tests around #[macro_escape]. Can it instead add a test that captures what does happen when you mention macro_escape? Is it an error?

Copy link Copy Markdown

Contributor

Copy link Copy Markdown

Contributor Author

@brson Currently, #[macro_escape] would have no effect, but I think it should be a custom_attribute feature error like other unknown attributes (I'll update and add a test when we want to land).

@nikomatsakis

At worst, we can have a warning period

It has been a deprecation warning since the beginning of 2015.

At least one of the grepped crates (immutable) is a real regression (many are already broken or have a dead GH repository link). There's very little downside to keeping #[macro_escape], so I'm going to close this PR until there are no regressing crates.