Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

📌 Commit 15a8fc2 has been approved by brson

Author

Thanks @brson in #32444 you mentioned something needs to change in src/rustbuild but im not sure what (and I cant see a folder with that name). Is that still relevant.

Also I cant see why the Travis build fail. It said all tests passed.

Author

Am I correct in saying that the other Tarballs have a version file created by the gen_installer.sh script?
How to I exercise this code to test it? You can just point me at the docs if they exist

Author

r? @brson

I have updated the rustbuild files. I just don't know how to drive the process to confirm it works :-/

Contributor

Am I correct in saying that the other Tarballs have a version file created by the gen_installer.sh script?
How to I exercise this code to test it? You can just point me at the docs if they exist

No, the version file is only created for the rustc installer and the source tarball, by the build script, and the one in the rustc tarball is later copied into the rust tarball by rust-packaging. The gen_installer.sh script doesn't care about the program version.

You can test with ./configure --enable-rustbuild && make dist

Author

ok I am happy with this commit. Both the rustc-1.13.0-dev-src.tar.gz and rustc-1.13.0-dev-x86_64-apple-darwin.tar.gz on my computer have a version file in them with the following content:

1.13.0-dev (8bb856cbf 2016-09-03)

Collaborator

📌 Commit 72da8b8 has been approved by brson

Collaborator

⌛ Testing commit 72da8b8 with merge a36e069...

Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: brson
Pushing a36e069 to master...