Status: This is awaiting some action (such as code changes or more information) from the author.

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Jul 24, 2026

rust-bors Bot pushed a commit that referenced this pull request

Jul 24, 2026

rustdoc: Only analyze head of self type when deciding impl inlining

We only care about whether the self type is a generic or an item
(inlined) in the current crate, so we don't actually need to compute the
param_env, which is expensive when done to every external impl.

camelid marked this pull request as ready for review

July 24, 2026 20:10

rustbot removed the S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

label

Jul 24, 2026

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 26, 2026

camelid added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 27, 2026

rustbot added the T-rustdoc-frontend

Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

label

Jul 27, 2026

rust-bors Bot added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 28, 2026

rust-bors Bot pushed a commit that referenced this pull request

Jul 28, 2026

rustdoc: Only analyze head of self type when deciding impl inlining
We only care about whether the self type is a generic or an item (inlined) in
the current crate, so we don't actually need to compute the param_env, which is
expensive when done to every external impl.  This PR avoids computing the
param_env until we actually decide to inline the impl.  Moreover, it adds
specialized cleaning logic for types that stops after the "head" (the top-level
structure) is constructed, which is enough for the self type-based impl
inlining analysis.

Open

rust-bors Bot pushed a commit that referenced this pull request

Jul 28, 2026

This feature is unstable but will be stabilized soon, and this is a good
way of dogfooding it to make sure it works properly. It should have no
effect on the generated docs, but it provides a significant speedup. For
example, I measure a 3x speedup locally (3m 11s -> 1m 1s) -- note that
this is with the latest rustdoc perf improvements (#159854).

rust-bors Bot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jul 28, 2026

rust-bors Bot added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 28, 2026

rust-bors Bot pushed a commit that referenced this pull request

Jul 28, 2026

rustdoc: Only analyze head of self type when deciding impl inlining
try-job: dist-x86_64-solaris

Open