rustbot · GitHub

@chirizxc

@rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Jul 11, 2026

@chirizxc

clarfonthey

clarfonthey

clarfonthey

Co-authored-by: Clar Fon <15850505+clarfonthey@users.noreply.github.com>

@chirizxc

clarfonthey

clarfonthey

rust-bors Bot pushed a commit that referenced this pull request

Jul 28, 2026
a bit optimize four-digit chunks in integer formatting

@rust-bors rust-bors Bot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jul 29, 2026

@chirizxc

inkreasing

@chirizxc

@rust-bors rust-bors Bot added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Aug 3, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request

Aug 3, 2026
a bit optimize four-digit chunks in integer formatting
<p>
  <img
    src="https://thesvg.org/icons/compiler-explorer/default.svg"
    alt="Compiler Explorer"
    height="16"
    valign="middle"
  />
  <a href="https://godbolt.org/z/aTr54hTvT">GodBolt</a>
</p>
Number of asm instructions has decreased (78 -> 59)
The current upstream version contains:
```asm
movabs  rax, 9999999999999999
cmp     rsi, rax
ja      .LBB0_2
```
(if `n > 9_999_999_999_999_999` -> go to panic)
But this function isn't part of the public API, so _I suppose_ we can use `assert_unchecked(n < 10_000_000_000_000_000);`
Similarly, `write_quad` has been moved to a separate fn to reduce duplication slightly

Closed

rust-bors Bot pushed a commit that referenced this pull request

Aug 4, 2026
…uwer
Rollup of 26 pull requests
Successful merges:
 - #153749 (Account for ownership mismatch on argument that doesn't meet bound)
 - #158727 (std: use `readdir` on nearly all UNIX platforms)
 - #159130 (a bit optimize four-digit chunks in integer formatting)
 - #159326 (Deny multiple EII impls on a single item)
 - #159535 (Optimize slice::contains for bytewise types)
 - #159595 (Promote loongarch32-unknown-none* to Tier 2)
 - #160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record})
 - #160320 (point at trait definition when it is used as a derive macro)
 - #160369 (When suggesting method names, prefer *exact* doc aliases over similar names)
 - #160406 (`DepKind` cleanups)
 - #160424 (Use `thread::available_parallelism` as the default limit for backend parallelism)
 - #159303 (Fix ICE for direct inline const generic defaults)
 - #159977 (Add regression test for bool indexing codegen)
 - #160011 (remove InterpError::map_err_info)
 - #160165 (reject `...` without pattern post-expansion)
 - #160295 (Fix rustdoc ICE when checking if a generic arg can be elided)
 - #160305 (Linkify C-SKY targets in `platform-support.md`)
 - #160314 (fix borrowck ICE for consts with fn pointer type)
 - #160322 (ElaborateBoxDeref: remove unnecessary projection)
 - #160338 (Add regression test for supertrait associated type normalization through dyn)
 - #160340 (Add regression test for unused_parens on contract clauses)
 - #160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`)
 - #160384 (Add PR body notes for Cargo lock file maintenance)
 - #160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser)
 - #160435 (bump tracing-tree)
 - #160449 (Fix lookup of object files)

jhpratt added a commit to jhpratt/rust that referenced this pull request

Aug 4, 2026
a bit optimize four-digit chunks in integer formatting
<p>
  <img
    src="https://thesvg.org/icons/compiler-explorer/default.svg"
    alt="Compiler Explorer"
    height="16"
    valign="middle"
  />
  <a href="https://godbolt.org/z/aTr54hTvT">GodBolt</a>
</p>
Number of asm instructions has decreased (78 -> 59)
The current upstream version contains:
```asm
movabs  rax, 9999999999999999
cmp     rsi, rax
ja      .LBB0_2
```
(if `n > 9_999_999_999_999_999` -> go to panic)
But this function isn't part of the public API, so _I suppose_ we can use `assert_unchecked(n < 10_000_000_000_000_000);`
Similarly, `write_quad` has been moved to a separate fn to reduce duplication slightly

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request

Aug 4, 2026
a bit optimize four-digit chunks in integer formatting
<p>
  <img
    src="https://thesvg.org/icons/compiler-explorer/default.svg"
    alt="Compiler Explorer"
    height="16"
    valign="middle"
  />
  <a href="https://godbolt.org/z/aTr54hTvT">GodBolt</a>
</p>
Number of asm instructions has decreased (78 -> 59)
The current upstream version contains:
```asm
movabs  rax, 9999999999999999
cmp     rsi, rax
ja      .LBB0_2
```
(if `n > 9_999_999_999_999_999` -> go to panic)
But this function isn't part of the public API, so _I suppose_ we can use `assert_unchecked(n < 10_000_000_000_000_000);`
Similarly, `write_quad` has been moved to a separate fn to reduce duplication slightly

Closed

rust-bors Bot pushed a commit that referenced this pull request

Aug 4, 2026
Rollup of 28 pull requests
Successful merges:
 - #153749 (Account for ownership mismatch on argument that doesn't meet bound)
 - #159130 (a bit optimize four-digit chunks in integer formatting)
 - #159326 (Deny multiple EII impls on a single item)
 - #159535 (Optimize slice::contains for bytewise types)
 - #159595 (Promote loongarch32-unknown-none* to Tier 2)
 - #160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record})
 - #160320 (point at trait definition when it is used as a derive macro)
 - #160369 (When suggesting method names, prefer *exact* doc aliases over similar names)
 - #160406 (`DepKind` cleanups)
 - #160424 (Use `thread::available_parallelism` as the default limit for backend parallelism)
 - #159303 (Fix ICE for direct inline const generic defaults)
 - #159977 (Add regression test for bool indexing codegen)
 - #160011 (remove InterpError::map_err_info)
 - #160165 (reject `...` without pattern post-expansion)
 - #160172 (tests: Enable `feature(stmt_expr_attributes)` in `2229_closure_analysis` tests)
 - #160295 (Fix rustdoc ICE when checking if a generic arg can be elided)
 - #160305 (Linkify C-SKY targets in `platform-support.md`)
 - #160314 (fix borrowck ICE for consts with fn pointer type)
 - #160322 (ElaborateBoxDeref: remove unnecessary projection)
 - #160338 (Add regression test for supertrait associated type normalization through dyn)
 - #160340 (Add regression test for unused_parens on contract clauses)
 - #160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`)
 - #160384 (Add PR body notes for Cargo lock file maintenance)
 - #160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser)
 - #160427 (Run try builds on EC2 by default)
 - #160435 (bump tracing-tree)
 - #160449 (Fix lookup of object files)
 - #160477 (Update the tracking issue for `borrowed_buf_init`)

rust-bors Bot pushed a commit that referenced this pull request

Aug 4, 2026
Rollup of 28 pull requests
Successful merges:
 - #153749 (Account for ownership mismatch on argument that doesn't meet bound)
 - #159130 (a bit optimize four-digit chunks in integer formatting)
 - #159326 (Deny multiple EII impls on a single item)
 - #159535 (Optimize slice::contains for bytewise types)
 - #159595 (Promote loongarch32-unknown-none* to Tier 2)
 - #160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record})
 - #160320 (point at trait definition when it is used as a derive macro)
 - #160369 (When suggesting method names, prefer *exact* doc aliases over similar names)
 - #160406 (`DepKind` cleanups)
 - #160424 (Use `thread::available_parallelism` as the default limit for backend parallelism)
 - #159303 (Fix ICE for direct inline const generic defaults)
 - #159977 (Add regression test for bool indexing codegen)
 - #160011 (remove InterpError::map_err_info)
 - #160165 (reject `...` without pattern post-expansion)
 - #160172 (tests: Enable `feature(stmt_expr_attributes)` in `2229_closure_analysis` tests)
 - #160295 (Fix rustdoc ICE when checking if a generic arg can be elided)
 - #160305 (Linkify C-SKY targets in `platform-support.md`)
 - #160314 (fix borrowck ICE for consts with fn pointer type)
 - #160322 (ElaborateBoxDeref: remove unnecessary projection)
 - #160338 (Add regression test for supertrait associated type normalization through dyn)
 - #160340 (Add regression test for unused_parens on contract clauses)
 - #160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`)
 - #160384 (Add PR body notes for Cargo lock file maintenance)
 - #160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser)
 - #160427 (Run try builds on EC2 by default)
 - #160435 (bump tracing-tree)
 - #160449 (Fix lookup of object files)
 - #160477 (Update the tracking issue for `borrowed_buf_init`)

rust-bors Bot pushed a commit that referenced this pull request

Aug 4, 2026
Rollup of 28 pull requests
Successful merges:
 - #153749 (Account for ownership mismatch on argument that doesn't meet bound)
 - #159130 (a bit optimize four-digit chunks in integer formatting)
 - #159326 (Deny multiple EII impls on a single item)
 - #159535 (Optimize slice::contains for bytewise types)
 - #159595 (Promote loongarch32-unknown-none* to Tier 2)
 - #160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record})
 - #160320 (point at trait definition when it is used as a derive macro)
 - #160369 (When suggesting method names, prefer *exact* doc aliases over similar names)
 - #160406 (`DepKind` cleanups)
 - #160424 (Use `thread::available_parallelism` as the default limit for backend parallelism)
 - #159303 (Fix ICE for direct inline const generic defaults)
 - #159977 (Add regression test for bool indexing codegen)
 - #160011 (remove InterpError::map_err_info)
 - #160165 (reject `...` without pattern post-expansion)
 - #160172 (tests: Enable `feature(stmt_expr_attributes)` in `2229_closure_analysis` tests)
 - #160295 (Fix rustdoc ICE when checking if a generic arg can be elided)
 - #160305 (Linkify C-SKY targets in `platform-support.md`)
 - #160314 (fix borrowck ICE for consts with fn pointer type)
 - #160322 (ElaborateBoxDeref: remove unnecessary projection)
 - #160338 (Add regression test for supertrait associated type normalization through dyn)
 - #160340 (Add regression test for unused_parens on contract clauses)
 - #160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`)
 - #160384 (Add PR body notes for Cargo lock file maintenance)
 - #160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser)
 - #160427 (Run try builds on EC2 by default)
 - #160435 (bump tracing-tree)
 - #160449 (Fix lookup of object files)
 - #160477 (Update the tracking issue for `borrowed_buf_init`)

Merged

rust-bors Bot pushed a commit that referenced this pull request

Aug 4, 2026
Rollup of 29 pull requests
Successful merges:
 - #153749 (Account for ownership mismatch on argument that doesn't meet bound)
 - #159130 (a bit optimize four-digit chunks in integer formatting)
 - #159326 (Deny multiple EII impls on a single item)
 - #159535 (Optimize slice::contains for bytewise types)
 - #159595 (Promote loongarch32-unknown-none* to Tier 2)
 - #160184 (Add -Zinstrument-mcount={fentry-nop-record,fentry-record})
 - #160320 (point at trait definition when it is used as a derive macro)
 - #160369 (When suggesting method names, prefer *exact* doc aliases over similar names)
 - #160406 (`DepKind` cleanups)
 - #160424 (Use `thread::available_parallelism` as the default limit for backend parallelism)
 - #160434 (Avoid Docker push when the image did not change)
 - #159303 (Fix ICE for direct inline const generic defaults)
 - #159977 (Add regression test for bool indexing codegen)
 - #160011 (remove InterpError::map_err_info)
 - #160165 (reject `...` without pattern post-expansion)
 - #160172 (tests: Enable `feature(stmt_expr_attributes)` in `2229_closure_analysis` tests)
 - #160295 (Fix rustdoc ICE when checking if a generic arg can be elided)
 - #160305 (Linkify C-SKY targets in `platform-support.md`)
 - #160314 (fix borrowck ICE for consts with fn pointer type)
 - #160322 (ElaborateBoxDeref: remove unnecessary projection)
 - #160338 (Add regression test for supertrait associated type normalization through dyn)
 - #160340 (Add regression test for unused_parens on contract clauses)
 - #160371 (Add doc aliases for transpositions `read_exact_buf` and `read_exact_buf_at`)
 - #160384 (Add PR body notes for Cargo lock file maintenance)
 - #160412 (Move duplicate-names check for #[rustc_must_implement_one_of] to attribute parser)
 - #160427 (Run try builds on EC2 by default)
 - #160435 (bump tracing-tree)
 - #160449 (Fix lookup of object files)
 - #160477 (Update the tracking issue for `borrowed_buf_init`)

@rust-bors

rust-timer added a commit that referenced this pull request

Aug 4, 2026
Rollup merge of #159130 - chirizxc:num_fmt, r=clarfonthey
a bit optimize four-digit chunks in integer formatting
<p>
  <img
    src="https://thesvg.org/icons/compiler-explorer/default.svg"
    alt="Compiler Explorer"
    height="16"
    valign="middle"
  />
  <a href="https://godbolt.org/z/aTr54hTvT">GodBolt</a>
</p>
Number of asm instructions has decreased (78 -> 59)
The current upstream version contains:
```asm
movabs  rax, 9999999999999999
cmp     rsi, rax
ja      .LBB0_2
```
(if `n > 9_999_999_999_999_999` -> go to panic)
But this function isn't part of the public API, so _I suppose_ we can use `assert_unchecked(n < 10_000_000_000_000_000);`
Similarly, `write_quad` has been moved to a separate fn to reduce duplication slightly

@chirizxc

WhySoBad pushed a commit to WhySoBad/miri that referenced this pull request

Aug 5, 2026

Open

Read the original on github.com ↗