rustbot
added
A-attributes
labels
May 28, 2026
rust-bors
Bot
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
Jul 29, 2026Merged
rust-bors Bot pushed a commit that referenced this pull request
Jul 29, 2026…uwer Rollup of 11 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159509 (Generate `valid_range`s for enums sign-agnostically) - #159632 (CFI: Add support for the adt_const_params feature) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #157058 (Rustdoc label badge for notable traits) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159850 (Add regression test for closure in array-length const generic) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160110 (convert rustc_hir::Target inherent methods to From impls) - #160123 (add additional license option for third-party dependencies) - #160131 (bootstrap: remove temporary bors email lookup)
rust-bors Bot pushed a commit that referenced this pull request
Jul 29, 2026…uwer Rollup of 11 pull requests Successful merges: - #158460 (Remove llvm_enzyme feature outside of bootstrap) - #159509 (Generate `valid_range`s for enums sign-agnostically) - #159632 (CFI: Add support for the adt_const_params feature) - #159671 (Add semver check test command for checking API compatibility of stdlib) - #157058 (Rustdoc label badge for notable traits) - #159717 (Add `-Zimplicit-sysroot-deps`) - #159850 (Add regression test for closure in array-length const generic) - #159994 (Show jobs where a given test was executed in `test-dashboard`) - #160110 (convert rustc_hir::Target inherent methods to From impls) - #160123 (add additional license option for third-party dependencies) - #160131 (bootstrap: remove temporary bors email lookup)
rust-timer added a commit that referenced this pull request
Jul 29, 2026Rollup merge of #157058 - ThierryBerger:rustdoc_label_trait, r=GuillaumeGomez Rustdoc label badge for notable traits - Part of #156865 - [x] reuse notable trait feature to feed badge data - [x] render it in html - [x] add some html tests - [x] Render a color from a hash from `its full path` - [x] fixed oklch hue-driven palette checked against wcag/apca Should the following be out of scope ? - [ ] Parse color (`#[doc(notable_trait(color="0xff0000")]`) - [ ] display a small colored indicator (with a hover/first letter?) when a type implementing a notable trait is listed outside of its main page - [ ] Some Integration with rust analyzer <img width="315" height="222" alt="Screenshot 2026-05-28 at 14 06 01" src="https://github.com/user-attachments/assets/2b7c19c4-0d6e-4ed7-8901-f82fba7fc122" /> ## Color discussion I went for the higher chroma, even though some values use a fallback, I'm not opposed to go for a less chromatic palette, but that's very bikeshedding so I'll defer to authority. with chroma 0.21: <img width="1048" height="274" alt="Screenshot 2026-06-30 at 21 57 27" src="https://github.com/user-attachments/assets/9f374295-4eb3-43ee-bffa-51276ffa39d2" /> with chroma 0.090: <img width="1037" height="274" alt="Screenshot 2026-06-30 at 21 58 38" src="https://github.com/user-attachments/assets/81d9c5b5-02a8-4f75-969f-0d4fc62bebd0" /> ## History Initially, this PR added a new feature "label_trait", it was then decided in [rustdoc meeting](https://hackmd.io/CxdTcVFTQPmBUrx-PWXTAw?view) to reuse current notable_trait feature.
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request
Aug 11, 2026JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request
Aug 11, 2026