RalfJung · GitHub

@RalfJung

@RalfJung mentioned this pull request

Nov 4, 2018

Closed

4 tasks

oli-obk

Ixrec

@Centril Centril added T-lang

Relevant to the language team, which will review and decide on the RFC.

T-dev-tools

Relevant to the development tools team, which will review and decide on the RFC.

labels

Nov 4, 2018

Centril

@RalfJung

@RalfJung

@Manishearth Manishearth removed the T-dev-tools

Relevant to the development tools team, which will review and decide on the RFC.

label

Apr 1, 2020

Closed

@rfcbot rfcbot added the final-comment-period

Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised.

label

Apr 7, 2020

pnkfelix

Closed

Open

5 tasks

@nikomatsakis

@RalfJung

RalfJung deleted the unsafe-block-in-unsafe-fn branch

April 29, 2020 13:39

Closed

Merged

jacob-hughes added a commit to jacob-hughes/alloy that referenced this pull request

Sep 8, 2020

michaellass added a commit to michaellass/aligned_box that referenced this pull request

Feb 13, 2021
Using a slice of elements that are not properly initialized is UB. Although
new_uninitialized_sliced is a private function, mark it as unsafe to make clear
that the caller has the responsibility to initialize all elements of the slice
without looking at the old contents.
For now we need to suppress warnings about the use of unsafe blocks in an
unsafe function. This will be changed based on RFC 2585. Marking a function as
unsafe and using unsafe code within that function should and will be two
different things: rust-lang/rfcs#2585

michaellass added a commit to michaellass/aligned_box that referenced this pull request

Jan 10, 2022
RFC #2585 has been updated to be an optional lint for now. We clearly want this
behavior, so use this lint for our code. While here, also enable some other
lints that sound useful.
We are actually missing a couple of unsafe{} blocks in unsafe functions, so
follow-up commits are needed to properly document the safety assumptions around
these.
See: rust-lang/rfcs#2585 (comment)
See: rust-lang/rust#71668

Closed

Merged

@faern faern mentioned this pull request

Jan 30, 2024

Merged

mkroening added a commit to mkroening/x86_64 that referenced this pull request

Jan 13, 2026
Documenting private items gives:
```
warning: this URL is not a hyperlink
  --> src/structures/paging/mapper/mapped_page_table.rs:54:9
   |
54 |     /// rust-lang/rfcs#2585.
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: bare URLs are not automatically turned into clickable links
   = note: `#[warn(rustdoc::bare_urls)]` on by default
help: use an automatic link instead
   |
54 |     /// <rust-lang/rfcs#2585.>
   |         +                                            +
```

Read the original on github.com ↗