rust-highfive · GitHub

I think the condition here was slightly off from before, so invert it subtly to
get what we want, lifting up anything in a workspace or binaries otherwise.
Closes rust-lang#3432

@alexcrichton

bors added a commit that referenced this pull request

Jan 12, 2017
Lift up workspace rlibs while building
I think the condition here was slightly off from before, so invert it subtly to
get what we want, lifting up anything in a workspace or binaries otherwise.
Closes #3432

@bors

@alexcrichton

This was referenced

Feb 7, 2017

Closed

Merged

Closed

Closed

Merged

@ehuss ehuss mentioned this pull request

Mar 11, 2021

Merged

bors added a commit that referenced this pull request

Mar 13, 2021
Fix logic for determining prefer-dynamic for a dylib.
The logic for determining if a dylib should use `prefer-dynamic` used to be something like "do not use prefer-dynamic if it is the current package".
The current logic has a strange behavior where it works as intended if there is only one package in the workspace, but a workspace with multiple packages will always use `prefer-dynamic`.
Instead of using `current_opt`, which isn't a good concept to use in a workspace, I switched this to be "primary" (a package selected on the command-line).
**History**
*  9879a0a  Initial prefer-dynamic behavior.
* #3221 changed to the faulty logic (see comments at #3221 (comment)). I think there was some confusion there.
* #3478 fixed the logic for one of the changed conditions, but not the one for prefer-dynamic

Read the original on github.com ↗