Conversation
Merged
WyriHaximus
changed the title
[WIP] Only close stream when the we reached end of the stream
Only close stream when the we reached end of the stream
jsor approved these changes Nov 26, 2018
clue
mentioned this pull request
Closed
WyriHaximus added a commit to WyriHaximus-secret-labs/stream that referenced this pull request
Dec 31, 2018clue approved these changes Dec 31, 2018
clue added a commit to clue-labs/socket that referenced this pull request
Jan 2, 2019Construct underlying stream to always consume complete receive buffer. This avoids stale data in TLS buffers and also works around possible buffering issues in legacy PHP versions. The buffer size is limited due to TCP/IP buffers anyway, so this should not affect usage otherwise. This builds on top of reactphp/stream#139 to work around a bug in PHP where reading from a TLS 1.3 stream resource would hang with 100% CPU usage due to the changed TLS 1.3 handshake.
clue
mentioned this pull request
Merged
Closed