WyriHaximus · GitHub

Conversation

Merged

@WyriHaximus WyriHaximus changed the title [WIP] Only close stream when the we reached end of the stream Only close stream when the we reached end of the stream

Nov 25, 2018

@WyriHaximus

jsor

jsor approved these changes Nov 26, 2018

@clue clue mentioned this pull request

Dec 31, 2018

Closed

staabm

clue

WyriHaximus added a commit to WyriHaximus-secret-labs/stream that referenced this pull request

Dec 31, 2018

staabm

kelunik

clue

clue approved these changes Dec 31, 2018

@WyriHaximus

@WyriHaximus

clue added a commit to clue-labs/socket that referenced this pull request

Jan 2, 2019
Construct underlying stream to always consume complete receive buffer.
This avoids stale data in TLS buffers and also works around possible
buffering issues in legacy PHP versions. The buffer size is limited
due to TCP/IP buffers anyway, so this should not affect usage otherwise.
This builds on top of reactphp/stream#139 to
work around a bug in PHP where reading from a TLS 1.3 stream resource
would hang with 100% CPU usage due to the changed TLS 1.3 handshake.

@clue clue mentioned this pull request

Jan 2, 2019

Merged

Closed

Read the original on github.com ↗