clue · GitHub

Conversation

clue commented
Jun 21, 2020
•

edited

Loading

Copy link Copy Markdown

Member

Builds on top of #235, #236, reactphp/event-loop#204 and others.

clue added the maintenance label

clue added this to the v1.5.0 milestone

clue force-pushed the windows branch from 86cb5f8 to 6992404 Compare

June 21, 2020 20:54

Run test suite on Windows

clue force-pushed the windows branch from 6992404 to e846bbb Compare

June 21, 2020 21:06

clue requested review from WyriHaximus and jsor

June 22, 2020 08:07

WyriHaximus reviewed Jun 22, 2020

View reviewed changes

Comment thread

tests/TcpConnectorTest.php

Comment thread

tests/HappyEyeBallsConnectorTest.php

WyriHaximus approved these changes Jun 22, 2020

View reviewed changes

jsor approved these changes Jun 23, 2020

View reviewed changes

jsor merged commit 31967e9 into reactphp:master

clue deleted the windows branch

June 23, 2020 08:23

clue mentioned this pull request

Work around broken composer install for legacy PHP on Windows #306

Merged

clue mentioned this pull request

[RFC] Improve tests to temporarily downgrade to Xdebug 3.4.1 due to segfaults #322

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants

Read the original on github.com ↗