Copy link Copy Markdown

Member

Minor fixes and improvements for examples/99-generate-self-signed.php discovered in #189

clue left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This repo still has a localhost_swordfish.pem and a number of references to this in the tests, do you think this should be updated as part of this PR? 👍

Copy link Copy Markdown

Member Author

@clue Yes, i noticed that as well. But i didn't find any direct references to this script. It's still possible to generate a cert with the password swordfish.

Copy link Copy Markdown

Member

@jsor Good, no objections then 👍

clue approved these changes Jan 24, 2019