WyriHaximus ยท GitHub

@WyriHaximus

Copy link Copy Markdown

Member

No description provided.

@WyriHaximus

@WyriHaximus

@clue

Copy link Copy Markdown

Member

The build output currently indicates that connecting to google.com with a timeout of 1 ms does not cause a timeout. Arguably, this test output could be a bit flaky depending on the timer resolution, the network speed and other factors. Is this something you're going to look into? ๐Ÿ‘

@WyriHaximus

Copy link Copy Markdown

Member Author

@clue currently looking into that, kicking that build a few times to ensure this was just a flaky run and not something more troubeling

@WyriHaximus

Copy link Copy Markdown

Member Author

@clue @jsor Ok kick the build for a good half hour and it only failed about 5% of the time so IMHO it's ready to be reviewed

clue

clue approved these changes Nov 11, 2018

jsor

jsor approved these changes Nov 12, 2018

@jsor

Read the original on github.com โ†—