jsor · GitHub

@andig

@andig andig commented

Oct 7, 2017

edited by clue

Loading

Copy link Copy Markdown

Contributor

Gets rid of the warnings and speeds up testing some.

Builds on top of #57

jsor

jsor approved these changes Oct 7, 2017

@WyriHaximus

WyriHaximus

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@andig @clue

@clue

@clue clue changed the title Fix test deprecations Forward compatibility with PHPUnit v5

Oct 7, 2017

clue

clue approved these changes Oct 7, 2017

@clue clue left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing this! I've amended your changes to also update the PHPUnit version in the composer.json, now let's get this in! :shipit:

@WyriHaximus

@andig

Read the original on github.com ↗