Contributor
In case you use pthreads or something else related to threading you might encounter this issue. It happens only with functions and is fixable only by adding these checks. Another way to avoid this is to wrap functions as static into classes.
Sounds like you're inheriting class and function definitions with pthreads, then including the Composer autoloader again. If this is the case, that's the real problem to be fixed.
If there is some other scenario that can lead to this problem, please describe it.
Contributor Author
Well, yes I need to include autoloader again. Without it I get undefined error. π
Will be checking few probably causes tomorrow.
I recommend using PTHREADS_INHERIT_INI only and then including the Composer autoloader in the thread.
Merged
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributor Author
@WyriHaximus Thank you!
I will make requested changes after I finish some critical work.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
One more thing, could you squash them into one commit?
jsor approved these changes Mar 21, 2019
clue approved these changes Mar 27, 2019
clue
mentioned this pull request
Merged
