trowski Β· GitHub

@NikoGrano

Copy link Copy Markdown

Contributor

In case you use pthreads or something else related to threading you might encounter this issue. It happens only with functions and is fixable only by adding these checks. Another way to avoid this is to wrap functions as static into classes.

@trowski

Copy link Copy Markdown

Sounds like you're inheriting class and function definitions with pthreads, then including the Composer autoloader again. If this is the case, that's the real problem to be fixed.

If there is some other scenario that can lead to this problem, please describe it.

@NikoGrano

Copy link Copy Markdown

Contributor Author

Well, yes I need to include autoloader again. Without it I get undefined error. πŸ™ƒ
Will be checking few probably causes tomorrow.

@trowski

Copy link Copy Markdown

I recommend using PTHREADS_INHERIT_INI only and then including the Composer autoloader in the thread.

Merged

@NikoGrano

Copy link Copy Markdown

Contributor Author

I'm using none currently, but lez see...

@NikoGrano

Copy link Copy Markdown

Contributor Author

@NikoGrano

Copy link Copy Markdown

Contributor Author

WyriHaximus

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus

@NikoGrano

Copy link Copy Markdown

Contributor Author

@WyriHaximus Thank you!

I will make requested changes after I finish some critical work.

@trowski

Copy link Copy Markdown

@NikoGrano

Copy link Copy Markdown

Contributor Author

Maybe because itΓ€s used by pool?
image

@NikoGrano

Copy link Copy Markdown

Contributor Author

WyriHaximus

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

One more thing, could you squash them into one commit?

@NikoGrano

Copy link Copy Markdown

Contributor Author

Sure!

@NikoGrano

@NikoGrano

Copy link Copy Markdown

Contributor Author

Done, ty.

jsor

jsor approved these changes Mar 21, 2019

@NikoGrano

Copy link Copy Markdown

Contributor Author

clue

clue approved these changes Mar 27, 2019

@clue

@clue clue mentioned this pull request

Mar 27, 2019

Merged

@WyriHaximus

Copy link Copy Markdown

Member

Cheers, will tag this shortly πŸ‘

@NikoGrano

Copy link Copy Markdown

Contributor Author

THANK YOU EVERYBODY!

@NikoGrano

@WyriHaximus

Copy link Copy Markdown

Member

Read the original on github.com β†—