SimonFrings · GitHub

@Ayesh

@SimonFrings

Closed

@SimonFrings

@SimonFrings SimonFrings changed the title Fix for implicit nullability deprecation (PHP 8.4) Improve PHP 8.4 support by using explicitly nullable type declarations

May 14, 2024

@SimonFrings SimonFrings changed the title Improve PHP 8.4 support by using explicitly nullable type declarations Improve PHP 8.4+ support by avoiding implicitly nullable type declarations

May 14, 2024

clue

clue approved these changes May 14, 2024

WyriHaximus

@WyriHaximus

This was referenced

May 16, 2024

Merged

Merged

WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request

May 22, 2024
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260.
I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs.
Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch.
Builds on top of reactphp#182, reactphp#222 and reactphp/promise#260

Merged

WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request

May 22, 2024
This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.
Builds on top of reactphp#223, reactphp#204 and reactphp#218

WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request

May 22, 2024
This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.
Builds on top of reactphp#223, reactphp#204 and reactphp#218

Merged

Merged

This was referenced

May 22, 2024

Merged

Merged

Merged

Merged

@clue clue mentioned this pull request

Jul 26, 2024

Merged

This was referenced

Aug 6, 2024

Merged

Merged

Merged

Merged

Merged

@clue clue mentioned this pull request

Sep 8, 2024

Merged

This was referenced

Nov 21, 2024

Merged

Merged

Merged

Merged

This was referenced

Dec 6, 2024

Merged

Merged

Closed

Closed

@clue clue mentioned this pull request

Dec 14, 2024

Closed

This was referenced

Dec 27, 2024

Merged

Merged

Merged

@clue clue mentioned this pull request

Jan 17, 2025

Merged

@clue clue mentioned this pull request

Jan 25, 2025

Closed

@clue clue mentioned this pull request

May 16, 2025

Merged

@ruudk ruudk mentioned this pull request

May 18, 2025

Closed

Closed

This was referenced

Jun 30, 2025

Open

Merged

This was referenced

Aug 18, 2025

Merged

Merged

@clue clue mentioned this pull request

Jan 24, 2026

Merged

@clue clue mentioned this pull request

Apr 13, 2026

Merged

Read the original on github.com ↗