Closed
SimonFrings
changed the title
Fix for implicit nullability deprecation (PHP 8.4)
Improve PHP 8.4 support by using explicitly nullable type declarations
SimonFrings
changed the title
Improve PHP 8.4 support by using explicitly nullable type declarations
Improve PHP 8.4+ support by avoiding implicitly nullable type declarations
clue approved these changes May 14, 2024
This was referenced
May 16, 2024Merged
Merged
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request
May 22, 2024This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs. Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch. Builds on top of reactphp#182, reactphp#222 and reactphp/promise#260
Merged
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request
May 22, 2024This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise. Builds on top of reactphp#223, reactphp#204 and reactphp#218
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request
May 22, 2024This changeset backports reactphp#223 from `3.x` to `1.x` to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise. Builds on top of reactphp#223, reactphp#204 and reactphp#218
Merged
Merged
This was referenced
May 22, 2024Merged
Merged
Merged
Merged
clue
mentioned this pull request
Merged
This was referenced
Aug 6, 2024Merged
Merged
Merged
Merged
Merged
clue
mentioned this pull request
Merged
This was referenced
Nov 21, 2024Merged
Merged
Merged
Merged
This was referenced
Dec 6, 2024Merged
Merged
Closed
Closed
clue
mentioned this pull request
Closed
This was referenced
Dec 27, 2024Merged
Merged
Merged
clue
mentioned this pull request
Merged
clue
mentioned this pull request
Closed
clue
mentioned this pull request
Merged
ruudk
mentioned this pull request
Closed
Closed
This was referenced
Jun 30, 2025Open
Merged
This was referenced
Aug 18, 2025Merged
Merged
clue
mentioned this pull request
Merged
clue
mentioned this pull request
Merged